[Cvsnt] gserver impersonation

[Brian Smith]

Tony Hoyle wrote:
> Brian Smith wrote:
>> Tony Hoyle wrote:
>>> On Tue, 26 Feb 2002 11:11:40 +0000 (UTC), Brian Smith
>>> <brian-l-smith at uiowa.edu> wrote:
>>>>     new_tok_buffer(ib, ((cbuf[0] & 0xff) << 8) | (cbuf[1] & 0xff));
>>>
>>> yuk.  Use ntohs to do this.
>> This is actually just copied and pasted out of the gserver code, but I
>> will change it.
>>
> Hmm... the gserver code is just a copy/paste from the original cvs code.
>  It shouldn't have any endianness issues (being cross platform code).
> It looks like it does, though.  Ugh.  I'm fixing *that* bogosity before
> it gets released...

I think that the semantics above are fine. I thought you just meant that
it should be changed because it looked ugly. I don't see any endian
issue with it; it is translating from network-byte-order to the native
byte order, which seems right to me.

> btw. Since I'll break sspi by using network byte ordering I've change
> the handshake slightly.  It now sends an extra line after the 'BEGIN

Ah, I wondered what that extra line was for!

- Brian

_______________________________________________
Cvsnt mailing list
Cvsnt at cvsnt.org
http://www.cvsnt.org/cgi-bin/mailman/listinfo/cvsnt