[cvsnt] Re: wnt_fclose and FlushFileBuffers

[John Goehringer]

Yes, removing FlushFileBuffers does solve the performance problem.

I saw the most effect on large checkouts - you can 'hear' the difference
in disk activity as the files are written to disk on the client. The server
seems to do the same - I guess from flushing the last accessed time of
the file.

I can get some comparison timings if you like.

Thanks,
John Goehringer

"Tony Hoyle" <tmh at nodomain.org> wrote in message
news:b1ul39$goj$1 at sisko.nodomain.org...
> Tony Hoyle wrote:
>
> > John Goehringer wrote:
> >
> >> Tony,
> >>
> >>     I'm seeing poor performance on both the client and server
> >> with build 69 compared to build 68 and tracked it down to
> >> the FlushFileBuffers call in win32.c:wnt_fclose.
> >>
> Hmm... seems to be OK now without it.  I'll have to run proper tests
though.
>
> Presumably if you remove the FlushFileBuffers your speed problems are
> solved?
>
> Tony
>