[cvsnt] Re: Problem with taginfo after upgrade to 2.5.02.2083

[Torsten Martinsen]

I found the problem. The crash occurs in info_trigger.cpp line 220:
 
int pret_enum_version_list(int num, const char **reslt, void *param)
{
        pretag_information *info = (pretag_information*)param;
        if(num>=info->name_list_count)
        {
                *reslt=NULL;
                return 0;
        }
        *reslt=info->version_list[num];
        return num+1<info->name_list_count;
}

It turned out that reslt was 0, so this patch makes things work for me:
 
*** info_trigger.cpp.~1.1.2.71.~        2005-09-07 01:26:45.000000000
+0200
--- info_trigger.cpp    2006-01-03 09:43:56.000000000 +0100
***************
*** 211,216 ****
--- 211,218 ----
 
  int pret_enum_version_list(int num, const char **reslt, void *param)
  {
+       if (!reslt)
+               return 0;
        pretag_information *info = (pretag_information*)param;
        if(num>=info->name_list_count)
        {

-Torsten



________________________________

	From: Torsten Martinsen 
	Sent: Wednesday, December 07, 2005 11:49 AM
	To: 'cvsnt at cvsnt.org'
	Subject: Problem with taginfo after upgrade to 2.5.02.2083
	
	
	After upgrading a (Debian 3.1) server from 2.0.51d, the tag
command fails:
	 
	    >cvs tag xxx README
	    cvs [tag aborted]: end of file from server (consult above
messages if any)
	 
	After some troubleshooting (-ttt does not give any useful
information, and I did not succeed in getting any server trace despite
following the instructions on
http://www.march-hare.com/cvspro/faq/faq5.asp#4L), I found out that the
culprit was the CVSROOT/taginfo file:
	 
	    ALL    /cvs/cvs-scripts/checktag
	
	Commenting out the line makes the tag succeed. However, even
this taginfo file
	 
	    ALL    /bin/true
	 
	still causes cvs tag to fail (this is the last few lines of the
trace):
	 
	11:48:23: S -> ACL lookup on directory /cvs/avet
	11:48:23: S -> verify_acl(tag,HEAD,(null))
	11:48:23: S -> user_state = 0, group_state = 0
	11:48:23: S -> no match at this level
	11:48:23: S -> RCS_getversion((null),(null),0)
	11:48:23: S -> RCS_getversion(xxx,(null),1)
	11:48:23: S -> run pretag proc
	11:48:23: S -> run_trigger()
	11:48:23: S -> Call pre-loaded 'default_trigger.la'
	11:48:23: S -> pretag_proc(fne/lang/mail,add,xxx,N)
	cvs [tag aborted]: end of file from server (consult above
messages if any)
	 
	-Torsten