[cvsnt] Changing Commit Dialog

[Joe.VanQuakebeke at Ingenix.com]

If the check fails then you need to have a non-zero exit status.  I use exit(-1); in my perl scripts.

Joe
> -----Original Message-----
> From: cvsnt-bounces at cvsnt.org 
> [mailto:cvsnt-bounces at cvsnt.org] On Behalf Of Bryan Leber
> Sent: Tuesday, September 19, 2006 7:55 AM
> To: Gabriel Genellina
> Cc: cvsnt at cvsnt.org
> Subject: Re: [cvsnt] Changing Commit Dialog
> 
> Gabriel,
> 
> Thanks for the help. I have constructed my script with your 
> advice. One question though. If one of the two mandatory 
> items aren't entered, it prints to the screen that it needs 
> to be fixed and it says the commit fails, but for some reason 
> it still adds it to my mailer script. Any ideas?
> 
> Bryan Leber
> Developer
> Fischer International Corporation
> www.fischerinternational.com
> bryan.leber at fischerinternational.com
> Cell:(239)963-5267
>  
> Secure Your Risk. Increase Your Bottom Line. (tm) 
> -----Original Message-----
> From: Gabriel Genellina [mailto:gagsl-cvsnt at yahoo.com.ar]
> Sent: Monday, September 18, 2006 4:58 PM
> To: Bryan Leber
> Cc: cvsnt at cvsnt.org
> Subject: Re: [cvsnt] Changing Commit Dialog
> 
> At Monday 18/9/2006 11:50, Bryan Leber wrote:
> 
> >PATCH_NUMBER: 9999
> >
> >BUG_NUMBER: 2341
> >
> >FEATURE_AFFECTED: Admin logon
> >
> >OVERVIEW: The logon logo has been changed
> >
> >
> >
> >I don't know if this is how it is suppose to work(i.e. put 
> what is in 
> >the comment file that I made also) or what, but im not sure 
> how I can 
> >parse through this and make sure that just the FEATURE_AFFECTED and 
> >OVERVIEW are there, because if they are left out the 
> FEATURE_AFFECTED 
> >and OVERVIEW words are still printed, so I assume that it would show 
> >that it is not empty.
> 
> This is actually a Python question. You should check that 
> there are text AFTER that words. Something like this:
> 
> faOK = ovOK = False
> for line in lines:
>      line = line.strip()
>      if line.startswith('FEATURE_AFFECTED:'): faOK = line[17:] != ''
>      if line.startswith('OVERVIEW:'): ovOK = line[9:] != ''
> if not faOK:
>    print "Missing FEATURE AFFECTED"
>    ret = 1
> elif not ovOK:
>    print "Missing OVERVIEW"
>    ret = 1
> else: ret=0
> sys.exit(ret)
> 
> 
> Gabriel Genellina
> Softlab SRL 
> 
> 
> 	
> 	
> 		
> __________________________________________________
> Preguntá. Respondé. Descubrí.
> Todo lo que querías saber, y lo que ni imaginabas, está en 
> Yahoo! Respuestas (Beta).
> ¡Probalo ya! 
> http://www.yahoo.com.ar/respuestas
> 
> 
> **************************************************************
> ************************************************************
> 
> This mail message may contain confidential and privileged 
> information from Fischer International which is protected. 
> Any unauthorized review, use, disclosure or distribution by 
> any means is prohibited. If you are not the intended 
> recipient, please contact the sender by reply email and 
> destroy all copies of the original message.
> 
> **************************************************************
> ************************************************************
> 
> _______________________________________________
> cvsnt mailing list
> cvsnt at cvsnt.org
> http://www.cvsnt.org/cgi-bin/mailman/listinfo/cvsnt
> 
> 

"Secure Server GDV" made the following
 annotations on 09/19/2006 09:05:56 AM
------------------------------"This e-mail, including attachments, may include confidential and/or proprietary information, and may be used only by the person or entity to which it is addressed. If the reader of this e-mail is not the intended recipient or his or her authorized agent, the reader is hereby notified that any dissemination, distribution or copying of this e-mail is prohibited. If you have received this e-mail in error, please notify the sender by replying to this message and delete this e-mail immediately."
==============================