[cvsnt] Can CVS require a check in comment?

[Arthur Barrett]

Thanks Jan!

> -----Original Message-----
> From: cvsnt-bounces at cvsnt.org 
> [mailto:cvsnt-bounces at cvsnt.org] On Behalf Of Prochazka, Jan
> Sent: Tuesday, 26 June 2007 12:38 AM
> To: cvsnt at cvsnt.org
> Subject: Re: [cvsnt] Can CVS require a check in comment?
> 
> 
> Hello Arthur,
> I believe I have submitted our solution at least twice. Nevertheless,
> here it is again:
> 
> the 'veryfimsg' file does have one line in it:
> 
> DEFAULT <server_local_absolute_path>\verifymsg.exe
> 
> and the verifymsg.cpp is:
> 
> // verifymsg.cpp : Defines the entry point for the console 
> application.
> //
> #include <stdio.h>
> #include <stdlib.h>
> #include <direct.h>
> #include <errno.h>
> #include <tchar.h>
> #include <atlstr.h>
> 
> int _tmain(int argc, _TCHAR* argv[])
> {
> 	char* buffer;
> 	CString msg, msgOrig="";
> 	FILE* msgFile; 
>     long lSize;
> 
> 	//something is wrong (file name should be here)
> 	if (argc <= 1){
> 		printf("\nSomething ir really wrong, file name is
> missing.\n\n");
> 		return 2;
> 	}
> 	if (NULL==(msgFile = fopen(argv[1],"rt"))){
> 		printf("\nSomething ir really wrong, can not open
> message file.\n\n");
> 		return 2;
> 	}
> 
> 	//jump to C
> 
>     // obtain file size.
> 	fseek(msgFile , 0 , SEEK_END);
> 	lSize = ftell(msgFile);
> 	rewind(msgFile);
> 
> 	// allocate memory to contain the whole file.
> 	buffer = (char*) malloc(lSize);
> 	if (buffer == NULL){
> 		printf("\nSomething ir really wrong, can not allocate
> message buffer.\n\n");
> 		fclose(msgFile);
> 		return 3;
> 	}
> 	// copy the file into the buffer.
> 	fread(buffer,1,lSize,msgFile);
> 
> 	/*** the whole file is loaded in the buffer. ***/
> 
>     fclose(msgFile);
> 	//add end of string
> 	buffer[lSize-1] = '\0';
> 	
> 	//jump back to C++
> 	 
> 	msgOrig = msg = buffer;
> 	free(buffer);
>     
> 	msg.Trim();
> 	
> 	//at least 1 space in the message
> 	if (msg.Find(" ") == -1){
> 		printf("\nPlease provide a more substantial commit
> message then \n\n");
> 		printf("'%s'\n\n",msgOrig);
> 		return 1;
> 	}
> 
> 	//at least 6 chaqracters   
> 	msg.Remove(' ');
> 	msg.Remove('\t');
> 	msg.Remove('\n');
> 	if (msg.GetLength() < 6){
> 		printf("\nPlease provide a more substantial commit
> message then \n\n");
> 		printf("'%s'\n\n",msgOrig);
> 		return 1;
> 	}
> 	
> 	//OK
> 	return 0;
> }
> 
> 
> > -----Original Message-----
> > From: Arthur Barrett [mailto:arthur.barrett at march-hare.com] 
> > Sent: Friday, June 22, 2007 22:35
> > To: Prochazka, Jan; cvsnt at cvsnt.org; Gerhard Fiedler
> > Subject: RE: [cvsnt] Can CVS require a check in comment?
> > 
> > Jan,
> > 
> > > > Educate the developers.  The technical fix isn't a solution.
> > > It is correct, that any technical fix can not protect you from 
> > > intentionally bad guys. However, it works great to prevent 
> > > unintentional mistakes, hurry up clicks etc. Really, I can 
> > not imagine 
> > > life without our precommit check looking for, if I remember 
> > correctly, 
> > > at least 2 words and at least 6 characters total.
> > 
> > Last time this issue came up I did suggest the person asking 
> > for this feature submit their script when they wrote it.  
> > They never did.  Do you want to submit a script.  You (or 
> > perhaps I can volunteer Gerhard) or someone can then add the 
> > example to the FAQ as well as the earlier comments.
> > 
> > As I and Tony at least said though - a blank comment is often 
> > OK (why require a crufty comment when none is required) - 
> > provided there is a bug number.  So the next release of 
> > 2.5.04 has the ability to require a bug number.
> > 
> > Regards,
> > 
> > 
> > Arthur Barrett
> > 
> > 
> _____________________________________________________________________
> > This email has been scanned by the MessageLabs Email 
> Security System.
> > 
> 
> _____________________________________________________________________
> This email message, including any attachments, may contain 
> confidential and proprietary information for the sole use of 
> the intended recipient.  If you are not the intended 
> recipient, you are hereby notified that any use, copying or 
> dissemination of this message is strictly prohibited.  If you 
> received this message in error, please notify Brooks 
> Automation, Inc. immediately by reply email or by calling 
> Brooks US Headquarters at +1 978-262-2400. Then delete this 
> message from your system, without making any copy or 
> distribution.  Thank you.
> _______________________________________________
> cvsnt mailing list
> cvsnt at cvsnt.org
> http://www.cvsnt.org/cgi-bin/mailman/listinfo/cvsnt
>