[cvsnt] Core dumps on Solaris 10

[Tom Halliley]

Plugins:
    # This file contains information about the state of the various 
protocols and external
    # plugins that are available.
    #
    # By default protocols are enabled, and other plugins are disabled.

    EnumProtocol=1                  # Remote enumeration (info -r)
    GserverProtocol=1               # GSSAPI
    PserverProtocol=1               # Original pserver
    SserverProtocol=1               # SSL encrypted pserver
    SspiProtocol=1                  # SSPI (via Winbind, if configured)

    #AuditTrigger=1                 # Audit events to database
    #EmailTrigger=0                 # Send emails
    #CheckoutTrigger=0              # Enable CVSROOT/shadow

Version:
    bash-3.00$ cvsnt --version

    Concurrent Versions System (CVSNT) 2.5.04 (Zen) Build 3236 () 
(client/server)

    CVSNT 2.5.04 (Nov  4 2008) Copyright (c) 2008 March Hare Software Ltd.
    see http://www.march-hare.com/cvspro

Unfortunately, when I enable tracing in PServer via:

    AllowTrace=1
    ServerTraceFile=/tmp/cvsnt.log

I get a client-side error of:

    bash-3.00$ cvsnt tag anothertag README.txt
    cvsnt [tag aborted]: end of file from server (consult above messages if 
any)

but when I disable tracing, I get:

    bash-3.00$ cvsnt tag anothertag README.txt
    T README.txt


as expected.

I'm using pserver for the time being in order to get triggers working 
correctly.  We'll probably switch to sserver after that.


Tom


BTW:  Here's the traceback from pstack on a core file:

    core 'core_source2_cvsnt_2087_30053_1229727373_15791' of 15791: 
/usr/local/bin/sparcv9/cvsnt -f --allow-root=/export/lo\
    cal/home/toolsa
     0000000100092518 _Z28client_protocol_buffer_flushPv (ffffffff7c006c28, 
ffffffff7f738304, ff000000, ff000000, 1210f4, f\
    fffffff7f737bb8) + 10
     000000010001a194 _Z9buf_flushP6bufferi (0, 0, ffffffff7f734c60, 
ffffffff7f625394, 1210f4, ffffffff7f502000) + 98
     000000010001a194 _Z9buf_flushP6bufferi (0, 0, ffffffff7f17c1fc, 
ffffffff7f1670a0, 0, ffffffff7f734530) + 98
     0000000100099ec0 _Z10cvs_outputPKcm (ffffffff7fffd490, 1f5, 400, 
ffffffff7f17c1fc, 0, ffffffff7f502000) + 10
     ffffffff7f1670c4 _ZN9CServerIo6outputEmPKc (1f5, ffffffff7fffd490, 460, 
0, ffffffffffffffff, ffffffff7d108d14) + 24
     ffffffff7f17c1fc _ZN8CRunFile4waitERii (ffffffff7fffd980, 
ffffffff7fffd974, ffffffffffffffff, ffffffff7fffd090, 0, 0) \
    + 610
     ffffffff7bb09fb4 
_ZN45_GLOBAL__N_info_trigger.cpp_AAEE1AA9_CF2775CF15parse_info_lineERSt6vectorISsSaISsEEPKcPNS_7optio\
    nsES7_S5_Rm (10022f3e8, 1002c2ac8, ffffffff7bc13478, ffffffff7bc12ee8, 
ffffffff7bb106e0, ffffffff7fffdb88) + 594
    ffffffff7bb0cf0c 
_ZN45_GLOBAL__N_info_trigger.cpp_AAEE1AA9_CF2775CF10parse_infoEPKcS1_S1_S1_PNS_7optionsES3_ 
(ffffffff\
    7bb106e0, ffffffff7bb106f8, ffffffff7bb10160, 1000f6890, 
ffffffff7bc13478, ffffffff7fffe140) + 950
     ffffffff7bb0d6b4 
_ZN45_GLOBAL__N_info_trigger.cpp_AAEE1AA9_CF2775CF11postcommandEPK19trigger_interface_tPKci 
(ffffffff\
    7bc13618, 1000f6890, 0, 7365727665720000, 38, 101010101010101) + 80
     000000010009a964 _Z16postcommand_procPvPK19trigger_interface_t (0, 
ffffffff7bc13618, 100233158, ffffffff7d4f7cc4, ffff\
    ffff7d4ec000, a800) + b4
     000000010006dc94 _Z11run_triggerPvPFiS_PK19trigger_interface_tE (0, 
10009a8b0, 5960, ffffffff7bc13618, ffffffff7fffe73\
    0, ffffffff7fffe510) + 6ec
     00000001000614e4 main (ac00, ac00, 0, a800, ffffffff7ffffdc0, a800) + 
1f58
     00000001000147ec _start (0, 0, 0, 0, 0, 0) + 7c

looks like the postcommand trigger has not yet officially completed and the 
error is occurring in the socket communications back to the client.


Here are messages from the bottom of the /tmp/cvsnt.log file:

    15:39:16: S -> cache_directory_permissions() 
free(/export/local/home/toolsadm/CVS_REPO)
    15:39:16: S -> cache_directory_permissions() return
    15:39:16: S -> verify_perm() Read directory permission cache OK
    15:39:16: S -> CXmlNode::CXmlNode(tree,node)
    15:39:16: S -> CXmlNode::Lookup(file[cvs:filename(@name,$name)]/acl)
    15:39:16: S -> xpath expression 'file[cvs:filename(@name,$name)]/acl' 
returned null resultset
    15:39:16: S -> user_state = 0, group_state = 0
    15:39:16: S -> no match at this level
    15:39:16: S -> user_state = 0, group_state = 0
    15:39:16: S -> no match at this level
    15:39:16: S -> verify_perm() return
    15:39:16: S -> tag_fileproc
    15:39:16: S -> Version_TS(<NULL>,<NULL>,0)
    15:39:16: S -> Version_TS - call 
RCS_getversion("/export/local/home/toolsadm/CVS_REPO/OIL/README.txt,v",<NULL>,<NULL>,0\
    , 0)
    15:39:16: S -> tag_fileproc - Version_TS complete
    15:39:16: S -> tag_fileproc() - numtag == NULL && date == NULL
    15:39:16: S -> * If we are adding a tag, we need to know which version 
we have checked
    15:39:16: S -> * out and we'll tag that version.
    15:39:16: S -> tag_fileproc() - nversion == NULL
    15:39:16: S -> tag_fileproc() - use vers->vn_user
    15:39:16: S -> tag_fileproc() - version = "1.14".
    15:39:16: S -> tag_fileproc - RCS_magicrev
    15:39:16: S -> tag_fileproc(4) rcs get version 
rcsfile="/export/local/home/toolsadm/CVS_REPO/OIL/README.txt,v" symtag="\
    anothertag"
    15:39:16: S -> tag_fileproc - finally RCS_settag
    15:39:16: S -> tag_fileproc - finally RCS_settag ok
    15:39:16: S -> tag_fileproc(2) rewrite 
rcsfile="/export/local/home/toolsadm/CVS_REPO/OIL/README.txt,v" 
symtag="anothert\
    ag", rev="1.14", date="2008.12.22.20.39.16"