[cvsnt] lock_time crash on Darwin 8 (Mac OSX 10.4)

[Draz, Kevin A]

Hello,

 

I've installed CVSNT 2.0.58d on Mac OS X 10.4 seed 8A369 (Darwin 8.0.0), and was getting a crash in cvslockd, in the function lock_time() in LockParse.cpp when a client (local or remote) would attempt to check out.  The crash was an invalid memory access to NULL, and the culprit was the call to times() [3] with an argument of NULL.  The function is expecting a pointer to a struct tms.  Apparently, this version of Darwin cannot accept a NULL argument.

 

The fix was simple - just create a local struct tms and pass it's address instead of NULL.  Checkouts now work.

 

The link to report bugs on http://www.cvsnt.org/wiki/BugReporting <http://www.cvsnt.org/wiki/BugReporting>  @ http://www.cvsnt.org/mantis/ <http://www.cvsnt.org/mantis/>  is loading a blank page, so I can't report this, but I wanted to share it anyway.

 

Here's a diff for the file lockservice/LockParse.cpp <attached>

 

KD